search

lokedhs / gnu-apl-mode

GNU APL mode for Emacs
GNU General Public License v3.0
94 stars 19 forks source link

Fixing byte compilation issues #42

Closed phikal closed 3 years ago

phikal commented 3 years ago

Hi,

I would like to add gnu-apl-mode to NonGNU ELPA, but before that is done, a few code issues should be fixed. The attached patches improve remove the deprecated cl library, and fix a number of issues raised by the byte compiler (see commit description).

If you decide to apply these changes, it would be necessary to bump the version attribute in the main file, so that ELPA recognizes a new release with these improvements.

lokedhs commented 3 years ago

Thanks. This sounds like a good idea. At least until I can get the copyright assignments done so that it can be posted to ELPA.

I'll take a look at your proposed changes.

phikal commented 3 years ago

ELPA is always preferable, but I am not sure what the state if of the other contributors with significant contributions (@fourier, @doyougnu, @ecraven). It might be manageable, but if for whatever reason it wouldn't be, I think it would be preferable to just add the package to NonGNU ELPA, that doesn't require any CA.

lokedhs commented 3 years ago

Yes, that's why I think it's a good idea. I have no idea when the copyright assignments will be done.

fourier commented 3 years ago

I have signed copyright papers and have code in ELPA if it helps.

lokedhs commented 3 years ago

I'd prefer not to merge the changes as-is, since they change spaces to tabs. Can you recommit with only spaces?

The commits themselves looks fine to me, but I might have missed something due to the noise caused by the spaces being changed to tabs.

phikal commented 3 years ago

Sorry about that, should be fixed now. I also hope it is ok to add a .dir-locals.el to make sure that this doesn't happen again in the future.

phikal commented 3 years ago

If you are interested, I could also add the Makefile I was using to the project. It could be used to set up a CI (though I don't know how GitHub does that).

lokedhs commented 3 years ago

If you are interested, I could also add the Makefile I was using to the project. It could be used to set up a CI (though I don't know how GitHub does that).

I don't mind at all. Integrating with the github builds is very easy.

phikal commented 3 years ago

Ok, as you see I have added the Makefile to this push request. I have no experience with GitHub Builds, so I hope you can take care of that.

phikal commented 3 years ago

Thank you for merging the changes.

In case you are still interested: All that is left for NonGNU ELPA would be to update the version tag, as indicated in the first message.

lokedhs commented 3 years ago

Thanks. Done.