lokenx / plexrequests-meteor

Meteor version of the original Plex Requests
http://plexrequests.8bits.ca
Other
528 stars 137 forks source link

[Request] Scrape Plex Library So PlexRequest Shows What is Already Available #305

Open magaman opened 8 years ago

magaman commented 8 years ago

With an ever growing library there is probably stuff people don't notice and might start requesting. It would be nice if PlexRequest could scrape the PMS library and mark the content as already available.

didyouexpectthat commented 8 years ago

When you go to request a show, it notifies you at that time that it exists. That's a lot of unnecessary information for plexrequests to keep track of, IMO.

magaman commented 8 years ago

Ahhhhh, but it's still retaining the data after the request is made, so wouldn't it make sense to already have that data within the plexrequest DB, instead of waiting to fill in the data on request the data is already being populated.

Foebik commented 8 years ago

I think a small updated to the way it tells users that it is downloaded should be made. When you request something that is already is in the library the button changes to "downloaded"; the user will look at that for a second to contemplate its meaning and might then notice the banner at the very bottom. But by the time they even see the banner it is already disappearing.

I would rather see a floating message that the user will need to click off to move on. PlexPy uses a lot of these through out its app to great affect (like on restart needed).

lokenx commented 8 years ago

So really two things:

  1. Search PMS (we currently check against SickRage/Sonarr/CouchPotato)
  2. Better/Persistent notifications

Regarding 1, my changes got pulled into a third party library so I'm working on getting that hooked up. I can't find reference to ID numbers from PMS, so matches will be based on title and year.

Regarding 2, I'll look into increasing timeout, moving location (top maybe?), and being dismissible (in conjunction with long timeout)

magaman commented 8 years ago

When you say Check against CP/Sonarr etc what do you mean because from my install even with it connected to CP if I search for something CP knows is in my library I still see a request button and no indication the item is in PMS already.

Personally I think the current notification isn't an issue, but if plexrequest did hook into PMS then when searched the user would see the "Downloaded" button instead of a "request" button then notification, my thought on this is making the user aware that the title is already in the PMS without a click and notification.

lokenx commented 8 years ago

If it's a new request it'll always have a Request button. However, on request we check CP, and if it's marked as done there, we add it and mark as done and don't re-add to CP. The button should change to Downloaded if available and Requested if not (add add to CP if it's not present).

I don't want to repopulate a database to keep track of things as well, so we only check on request and then store it. Hooking into Plex wouldn't change this behaviour though.

magaman commented 8 years ago

I think this is where I'm getting confused or not explaining it well. I understand not wanting to track everything, but as you said if requested and content exists in CP then it's stored as downloaded, My thought is scrape and store that data in advance instead of waiting for a request to be made. Even if it's a single scan on initial install, since in theory after installed most requests will filter through plexrequest anyway. Technically you wouldn't even have to hook into plex, couldn't it be accomplished with current hooks into CP/Sonarr etc??

lokenx commented 8 years ago

We want to hook into Plex for those users that don't rely on downloaders and for more accuracy. With CP you could have a lower quality version available but it won't get marked as done until a certain quality is obtained.

And it was simply a design decision to no pre-populate the data.

jrdnlc commented 8 years ago

Is this ever going to be implemented?

krismyklebust commented 8 years ago

+1 for this. Would love to see a "downloaded/available" button instead of "request" when searching for media that already exists in the Plex Library.

MRHGST commented 8 years ago

Would like to see this implemented as well.

RickyGrassmuck commented 8 years ago

Wouldn't the logical flow be to look on plex first before requesting media? I may be in the minority but I tend to search plex for what i want and if it's not there hop on plex requests from my phone and make the request

krismyklebust commented 8 years ago

Most definitely, unless you don't use Plex, and you're not at home to check the content on your home theatre PC ;) We use Kodi. Plex Media Server only runs as a backend so Plex Requests can check if content is available (we don't want Plex to be reachable from outside the LAN).

tidusjar commented 8 years ago

Just going to chime in here.

In my .NET version we have a background scheduler set up and we query Plex every X minutes (30) and cache the results. When we search for a movie/tv show we check if it's in the cache.

The way it has been done in our version does not affect performance in the slightest.

harrisonlingren commented 7 years ago

Any update here? I'd love for it to check against PMS for available content

tylerforesthauser commented 7 years ago

+1

dazw86 commented 7 years ago

This would be great, any news on when it may be implemented please?

david-zaletanski commented 6 years ago

This has been open but I would like to suggest it as well. My users are not the most pro-active bunch and end up re-downloading things that already exist all the time. From what I read it won't if it's already in couch potato but there are plenty of movies on Plex that were added manually (before I found PlexRequests :wink: ).