search

lokesh / lightbox2

THE original Lightbox script (v2).
http://lokeshdhakar.com/projects/lightbox2/
MIT License
6.24k stars 1.77k forks source link

Block the Overflow #310

Open raphael-arce opened 10 years ago

raphael-arce commented 10 years ago

Hello,

i'm trying to learn by myself webdesign and english is not my main language, so please excuse my bad english/explanation of my issue. After adding the Lightbox2 to my website, i observed that it is possible to scroll when the lightbox is open. How could you block the scrolling (i think it is named the overflow) when the lightbox ist open ?

Thanks for the great work, Greetings, Multiflux

kafeltz commented 10 years ago

Good question. This could be a nice feature to add-on.

matheuslc commented 10 years ago

So, the user has to close the modal for have scroll again?

raphael-arce commented 10 years ago

Yes, kind of "locking" the screen while the lightbox is open.

matheuslc commented 10 years ago

I understand. Add another option, like, "noScroll" and If this option is true, we block the scroll, if isn't, stay unblocked. What's you think?

matheuslc commented 10 years ago

@Multiflux I made this option, can you test? * I made a pull request, but you can test now downloading from my fork.

raphael-arce commented 10 years ago

Exactly what i've searched for. Great work ! Thank you very much.

matheuslc commented 10 years ago

@Multiflux I'm glad for that, thank you.