Open helloilya opened 8 years ago
Looks good, let's get it in.
Use a var like $lb-image-path: '../images' !default;
. It's not uncommon for people to use lots of @import
s in their sass/scss, making the relative pathing confusing/wrong. That's why bootstrap-sass does it.
Improved styles, fixed a few wrong moments.
LGTM
+1
This is an old PR that rewrites the CSS with SASS. I wanted to chime in on why it wasn't merged for anyone who comes across it in the future. For this project I've opted to keep the barrier for usage and outside development very low. So this means no precompilers. At one point I had switched to Coffeescript which caused significant confusion for those unfamiliar with it.
Also, at this point, SASS is making way for PostCSS. And with the minimal amount of CSS in the project, it isn't worth it IMHO.
For features like this that aren't on the roadmap I keep the PRs open so they are visible for others who might be interested in utilizing the code.
Added sass preprocessor support (issue #495), added
buildsass
grunt task (sass/autoprefixer).