Can you add all images as base64 encoded images to CSS? That saves 4 HTTP requests -> Speed!

lokesh / lightbox2

THE original Lightbox script (v2).

http://lokeshdhakar.com/projects/lightbox2/

MIT License

6.22k stars 1.77k forks source link

Can you add all images as base64 encoded images to CSS? That saves 4 HTTP requests -> Speed! #510

Closed cpl-repo closed 8 years ago

cpl-repo commented 8 years ago

Hi lokesh,

great plugin! Can you add those images as base64 encoding to CSS, that would save 4 HTTP request which speeds up a lot: http://cl.ly/3X3V3c383E1m

Cheers, Chris

cdp1337 commented 8 years ago

Hey Chris, I actually switched them to FontAwesome in my local fork; as that's already included in this specific project. You could try that as well by adding the necessary <i> tag and remove the background: url(...)

lokesh commented 8 years ago

The concern about reducing excessive HTTP requests has been noted. Though this issue will be less of a concern HTTP/2, it is still a legitimate performance issue now. My plan for v3 of the script is to use inline svgs to solve this issue. Less requests and no additional dependencies.