search

lokesh / lightbox2

THE original Lightbox script (v2).
http://lokeshdhakar.com/projects/lightbox2/
MIT License
6.22k stars 1.77k forks source link

Bootstrap glyphicon support #538

Closed bufferUnderrun closed 8 years ago

bufferUnderrun commented 8 years ago

Hi,

This patch use the glyphicon of twitter bootstrap instead of images and saves 4 network queries.

lokesh commented 8 years ago

Thanks for the PR. This isn't common enough of a request to move into the main codebase but hopefully other glyphicon fans can utilize it.

The concern about reducing excessive HTTP requests has been noted. Though this issue will be less of a concern HTTP/2, it is still a legitimate performance issue now. My plan for v3 of the script is to use inline svgs to solve this issue. Less requests and no additional dependencies.

bufferUnderrun commented 8 years ago

Ok thanks