Bugfix - MaxHeight wouldn't work.

lokesh / lightbox2

THE original Lightbox script (v2).

http://lokeshdhakar.com/projects/lightbox2/

MIT License

6.19k stars 1.76k forks source link

Closed ruimnetob closed 5 years ago

ruimnetob commented 7 years ago

Seems like there is a bug in line 306, the code is comparing against width but we want height.

Previously the 'maxHeight' in lightbox.options, wouldn't work properly. I tested it after correcting and now the image is resizing properly.

lokesh commented 5 years ago

oof. Sorry I missed this PR. Thanks for noting the issue and sending the fix.

ruimnetob commented 5 years ago

oof. Sorry I missed this PR. Thanks for noting the issue and sending the fix.

:) glad to have contributed. Thank you for making this great library!