search

lokesh / lightbox2

THE original Lightbox script (v2).
http://lokeshdhakar.com/projects/lightbox2/
MIT License
6.19k stars 1.76k forks source link

Added embed video feature #564

Open peppertom opened 7 years ago

miyagisan221b commented 7 years ago

This works pretty well, except the play button (YouTube) isn't really clickable without some real precision. Example: https://www.screencast.com/t/B2Ha5SHj

peppertom commented 7 years ago

Thanks @miyagisan85, I really appreciate Your comment!

Actually my latest commit (02f0d6e) is about fixing the border (box-sizing) and in update navigation styles over video (d66b03d) I updated the video navigation so that the video could easily be controlled.

Please find my gif in which I highlight the nav areas and the YouTube play button.

http://i.imgur.com/q9dJS1V.gifv

miyagisan221b commented 7 years ago

Ahh - it appears I downloaded the wrong version. I must have had a moment and thought the latest commit was at the top. Good show @peppertom, it appears to be working perfectly now. Hopefully this is merged in with the main project soon.

peppertom commented 7 years ago

thanks @miyagisan85

Luc45 commented 5 years ago

Hi @lokesh, any plans for merging this? Video support would be a great addition to the library.

lokesh commented 5 years ago

No plans to merge this in to Lightbox v2 as the project is in maintenance mode and I'm not making significant changes besides fixing bugs. I do appreciate the PRs and hopefully people can pick through the code they need in their personal fork.

I am considering video support for the next major release but that is still in brainstorming mode and without a timeline.

awannawa commented 4 years ago

thankyou verry much for adding this feature.. but can i set deactivate autoplay video after i click the image?

Catarina6 commented 3 years ago

Can someone help me?

I tried lightbox code but it does not pop up the youtube video. Instead it opens the youtube website.

`

NAME NAME

SUBTITLE

                <div class="image">
                    <img src="img/portfolio_item_4.png">
                </div>
            </div></a></a>
        </div>`
peppertom commented 3 years ago

@Catarina6 Please check out the example: https://github.com/peppertom/lightbox2/blob/master/examples/video.html