search

lokesh / lightbox2

THE original Lightbox script (v2).
http://lokeshdhakar.com/projects/lightbox2/
MIT License
6.19k stars 1.76k forks source link

Jquery 3.x #582

Closed hurrycaner closed 6 years ago

hurrycaner commented 7 years ago

Does lightbox2 works with jquery 3? If positive, is it possible to update bower dependencies to >2 instead of ~2?

pschfr commented 7 years ago

Yup! Check this CodePen!

bgeree commented 7 years ago

Nope! Try the following option: 'albumLabel': false

You'll get this error in console: this.options.albumLabel.replace is not a function

lokesh commented 6 years ago

Work w/jQuery 2>. I have a pending change to update the bower.json jquery dep requirements: https://github.com/lokesh/lightbox2/pull/614

re: this.options.albumLabel.replace is not a function The albumLabel prop must be a String and not a Boolean.

lokesh commented 6 years ago

Resolved: https://github.com/lokesh/lightbox2/releases/tag/v2.10.0