lokesh / lightbox2

THE original Lightbox script (v2).
http://lokeshdhakar.com/projects/lightbox2/
MIT License
6.17k stars 1.76k forks source link

Caption links handlers doesn't trigger #635

Closed installero closed 5 years ago

installero commented 5 years ago

This code here prevents any other handlers attached to caption links to trigger:

        .find('a').on('click', function(event) {
          if ($(this).attr('target') !== undefined) {
            window.open($(this).attr('href'), $(this).attr('target'));
          } else {
            location.href = $(this).attr('href');
          }
        });

What version of Lightbox2 you are using?

2.10.0

Which browsers and operating systems have you seen the issue on?

FireFox 64.0 on Ubuntu 16.04 (I believe this doesn't matter)

What are the steps to reproduce the bug?

Here's an example:

https://gist.github.com/installero/d5028228d903928f28afad8f6c0f6d60

Do you have link to a live site where the bug is visible? or can you post relevant HTML, CSS, and Javascript?

Demo: https://gracious-hopper-3dfc38.netlify.com/

lokesh commented 5 years ago

Fixed in v2.11.0: https://github.com/lokesh/lightbox2/releases/tag/v2.11.0