lokesh / lightbox2

THE original Lightbox script (v2).
http://lokeshdhakar.com/projects/lightbox2/
MIT License
6.14k stars 1.77k forks source link

Images not expanding in Microsoft Edge browser any more? #701

Closed NJWebDesign closed 1 year ago

NJWebDesign commented 3 years ago

Has something changed in Microsoft Edge browser? Images are no longer expanding in Microsoft Edge, yet they were doing so previously. Only appears to be affecting Edge. Any ideas?

Can be replicated by clicking the "Gallery" link on this page and selecting any of the left/right scrollable images: https://www.gallowaycottageholidays.com/index.php

Any advice would be greatly appreciated, thank you. NJ

erthi16 commented 3 years ago

It's not working in my Edge version 88 with no error but I get a violation error in my Chrome version 88 console everytime I click an image in your gallery. Firefox works fine version 85.

jquery-latest.pack.js:3 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

The lightbox only works outside of your slider...

NJWebDesign commented 3 years ago

...only on Edge browser. It works inside the slider in every other browser. :S

jquery-latest.pack.js is a DMXzone file associated with their Google Maps extension for Dreamweaver so maybe that's causing the problem?

I wouldn't know how to mark an event handler as 'passive'. :S

NJWebDesign commented 2 years ago

Haven't found any solution to this yet. How do I mark an event handler as "passive" and, even if I did fix that, why wouldn't that be causing a problem in other browsers. Thank you.

lokesh commented 1 year ago

Closing older issues.

I didn't receive additional reports about Edge issues so I'm assuming this was an issue with the specific implementation (e.g. conflict with another script on the page).

NJWebDesign commented 1 year ago

This is still an issue in Edge browser. Lightbox2, as I have it set up, works in every browser apart from Edge.

NJWebDesign commented 1 year ago

Lokesh, the issue remains with Edge browser. Lightbox doesn’t work in that browser.

Regards Nathon Jones Manager

Telephone: 01671 404 924 Skype: skype:nathonjones E-mail: @.*** Website: https://www.nathonjones.comhttps://www.nathonjones.com/

@.***

Responsive Website Design • Content Management • eCommerce • Domain Name Registration • Dedicated Business E-mail • Website Hosting • Technical Support • Graphic & Logo Design

Nathon Jones Website Design | The Vault Arts Centre | 40 Victoria Street | Newton Stewart | Wigtownshire | Dumfries & Galloway | Scotland | DG8 6BT

This e-mail communication, together with any attachments that may be transmitted with it, is intended only for the use of the addressee and may contain information which is privileged and confidential. If you are not the intended recipient you are hereby notified that any use of this e-mail is strictly prohibited. If you have received this e-mail in error please immediately delete it and any copies of it. Any opinions expressed in this e-mail are those of the author and do not necessarily constitute the views of Nathon Jones Web Design. Nothing in this e-mail shall bind Nathon Jones Web Design in any contract or obligation.

From: Lokesh Dhakar @.> Sent: Tuesday, February 21, 2023 6:52 PM To: lokesh/lightbox2 @.> Cc: Nathon Jones @.>; Author @.> Subject: Re: [lokesh/lightbox2] Images not expanding in Microsoft Edge browser any more? (#701)

Closing older issues.

I didn't receive additional reports about Edge issues so I'm assuming this was an issue with the specific implementation (e.g. conflict with another script on the page).

— Reply to this email directly, view it on GitHubhttps://github.com/lokesh/lightbox2/issues/701#issuecomment-1438949177, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB46GU5E2T4WA4ZKHVCEPYDWYUFGFANCNFSM4V55GVMQ. You are receiving this because you authored the thread.Message ID: @.***>