search

loki-47-6F-64 / sunshine

Host for Moonlight Streaming Client
GNU General Public License v3.0
1.74k stars 155 forks source link

Don't request D3D 11.1 device #36

Open mirh opened 4 years ago

mirh commented 4 years ago

Or at least have a check for that, I don't know if it wouldn't actually lead to some improvements. It should make the thing work in windows 7

cgutman commented 2 years ago

The Desktop Duplication API is Windows 8+ only, so it still wouldn't work on Windows 7.

mirh commented 2 years ago

Mhh well, putting aside there should be a drop-in replacement for that (and then idk if other grabbers couldn't be faster or more flexible, for the future) the point still seems that you don't need newer directx at all.

cgutman commented 2 years ago

There are plenty of other Windows 7 compatibility issues.

In addition to the Desktop Duplication API problem:

While none of these are strictly show-stopping, all together they represent an ongoing maintenance burden supporting all the way back to Windows 7 (including making sure all future features work, or at least don't break Win7). I don't think it's worth investing our time to implement multiple capture backends and other workarounds to support a platform that's been out of support for 1.5 years. Ultimately it's @loki-47-6F-64 's call though.

mirh commented 2 years ago

I'm not asking for W7 support (well, not directly at least). I'm just saying that you shouldn't inflate requirements randomly.

Now that I check better though, the 11.1 requirement isn't out of the blue, it comes from the D3D11_CREATE_DEVICE_VIDEO_SUPPORT flag. Which sounds somewhat relevant.. but I thought that was just about accelerating video decoding through d3d11?