search

loki4j / loki-logback-appender

Fast and lightweight implementation of Logback appender for Grafana Loki
https://loki4j.github.io/loki-logback-appender/
BSD 2-Clause "Simplified" License
314 stars 27 forks source link

Limit max batch size in bytes #48

Closed nehaev closed 3 years ago

nehaev commented 3 years ago

Add an option to limit max batch size in bytes. This could prevent issues like #24

ArchangelX360 commented 3 years ago

That would be awesome as Loki host on Grafana Cloud has a pretty aggressive limitation of 65536 Bytes!

joffrey-bion commented 3 years ago

Yes it would be really great! We currently had to put a batchSize of 1 to be able to handle our biggest logs, but this means that little logs get sent one-by-one now, which is not ideal.

nehaev commented 3 years ago

Work on this feature is now in progress, mostly in this branch. Hopefully, I will be able to come up with a reliable implementation in the nearest future, so this can be included into 1.1.0 release. Otherwise, I will have to postpone it to next releases.

nehaev commented 3 years ago

Some preparations for this are done in 1.1.0, but the complete implementation is not there yet. Postponing to 1.2.0.

ArchangelX360 commented 3 years ago

@nehaev Thanks for adding this 🙏 , any ETA on 1.2.0?

nehaev commented 3 years ago

Hey @ArchangelX360! A release candidate for 1.2.0 should be out within a few days, and a release will follow in about a week after that if no bugs reported.

ArchangelX360 commented 3 years ago

Thank you for the release 🙏🏼

nehaev commented 3 years ago

Thanks for using Loki4j! Please let me know if there are any issues or things need to be improved.