lokidoki102 / pe

0 stars 0 forks source link

Wrong parameter for parse in the Edit command in the sequence diagram in DG #11

Open lokidoki102 opened 2 months ago

lokidoki102 commented 2 months ago

The same issue mentioned about add command can be seen in edit command sequence diagram as well.

The parse() method should be taking in only the arguments and not the whole command word + arguments.

image.png

image.png

nus-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Wrong parameter for parse in the add command in the sequence diagram in DG

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


In this sequence diagram it says person is a combination of the command word + the arguments.

However, parse(person) does not reflect what is actually in the code.

image.png

In this screenshot below, it can be seen that the arguments and command word is separated, where only the arguments were used for the parse() parameter.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#384] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: While both bugs are related to parameter issues in sequence diagram, I disagree that this bug is a duplicate of the other as they are not from the same sequence diagram.

According to PE info, such bug should be treated separately.

image.png