search

lokidoki102 / pe

0 stars 0 forks source link

Add command does not handle extra white space (typo) for company name #3

Open lokidoki102 opened 2 months ago

lokidoki102 commented 2 months ago

Steps to reproduce

Currently, the application allows the addition of these 2 similar companies Happy Burger and Happy Burger, where the second one has 2 whitespaces which could be easily reproduced by the user on accident if they accidentally made a typo.

First run this command: add c/Happy Burger p/98765432 e/HappyBurger@example.com a/311, Clementi Ave 2, #02-25 t/I jd/Software Developer intern d/29-05-2024 1200 id/3 months s/1000 n/Company CEO is John Doe

Then run this command: add c/Happy Burger p/98765432 e/HappyBurger@example.com a/311, Clementi Ave 2, #02-25 t/I jd/Software Developer intern d/29-05-2024 1200 id/3 months s/1000 n/Company CEO is John Doe

Note how there's extra whitespace in Happy Burger in the second add command.

image.png

Expected

It should warn the user that a same internship has been added under the same company.

Actual

A duplicate company is created, although with a typo.

Suggestion

I think this type of cases should be handled as making typo with extra whitespace is plausible, and it should at least give the user a warning.

nus-pe-script commented 2 months ago

Team's Response

Our add currently does not have handling for extra spaces in between two words to provide flexibility for the user to input any company name they want.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree, this bug should not be classified as not in scope.

The PE info website has stated that issues pertaining to extra space between two names should be considered as a bug as they are unlikely to mean two different entities. In this case, Happy Burger and Happy Burger (with 2 whitespace in-between) is likely to be the same company and should be detected by the application to warn the user of such near match cases.

image.png