search

lokidoki102 / pe

0 stars 0 forks source link

Delete command is showing wrong error message #4

Open lokidoki102 opened 2 months ago

lokidoki102 commented 2 months ago

Steps to reproduce

Currently when running the command delete 0, it shows a warning that the command format is invalid rather than warning the user that it's invalid index.

run: delete 0

Expected

It should warn the user that the The internship application index provided is invalid

Actual

It shows an invalid command format error

image.png

nus-pe-script commented 2 months ago

Team's Response

Although our error message is not as specific, it does clearly state the issue, which is that 0 is not a positive integer. Albeit it is on the third line.

Furthermore, in our UG we stated that INDEX must be positive

Screenshot 2024-04-20 at 4.57.56 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree that this bug is not in scope.

Even though it is mentioned in the UG and in the error message that it should be a positive integer, the error message still mentioned that it is an "Invalid command format!" despite delete 0 being in the correct format. The command delete 0 clearly follows delete INDEX format as indicated by the UG. Rather than being an invalid command format, this should be a case of an invalid INDEX.