lokielse / omnipay-wechatpay

(微信支付)WeChatPay driver for the Omnipay PHP payment processing library
MIT License
315 stars 103 forks source link

return_code 此字段是通信标识,非交易标识,交易是否成功需要查看result_code来判断 #17

Closed shinvdu closed 7 years ago

shinvdu commented 7 years ago
    public function isSuccessful()
    {
        $data = $this->getData();
        return isset($data['return_code']) && $data['return_code'] == 'SUCCESS';
    }

https://github.com/shinvdu/omnipay-wechatpay/blob/master/src/Message/BaseAbstractResponse.php#L23

没有做result_code判断。

建议改为

return (isset($data['return_code']) && $data['return_code'] == 'SUCCESS' && isset($data['result_code']) && $data['result_code'] == 'SUCCESS');