lokinmodar / Echoglossian

FFXIV Dialogue text translator
Creative Commons Attribution 4.0 International
79 stars 16 forks source link

CJK fonts issue #37

Closed KihwaH closed 1 year ago

KihwaH commented 2 years ago

Hi, I really appreciate the update today. Your plugin really helped playing 6.0 before it stopped working.

As far as I remember Korean displayed fine back then, but for some reason now it's missing Korean fonts now.

1

I still think this is Dalamud problem rather than Echoglossian's, though. Dalamud has problem with Korean fonts. I've tried posting about this in their Discord a couple times but no luck.

2

(Same happens with AXIS fonts)

For extra context, FFXIV doesn't have Korean fonts and will display all Korean in "=", same thing in Dalamud too. Korean players have been using a mod to display Korean characters ingame(take a closer look at my chat log), but I do not exactly know about inner workings. Probably it replaces the font with the one from the Korean client.

lokinmodar commented 2 years ago

Hi, I really appreciate the update today. Your plugin really helped playing 6.0 before it stopped working.

As far as I remember Korean displayed fine back then, but for some reason now it's missing Korean fonts now.

1

I still think this is Dalamud problem rather than Echoglossian's, though. Dalamud has problem with Korean fonts. I've tried posting about this in their Discord a couple times but no luck.

2

(Same happens with AXIS fonts)

For extra context, FFXIV doesn't have Korean fonts and will display all Korean in "=", same thing in Dalamud too. Korean players have been using a mod to display Korean characters ingame(take a closer look at my chat log), but I do not exactly know about inner workings. Probably it replaces the font with the one from the Korean client.

Hello! For my plugin it shouldn't be happening because it enforces NotoSans on its windows. I'll need to have a deeper look into this.

Do you select Axis to be used in dalamud? Also, which mod your friends are using? I want to see if I can port their fonts to Eglo.

Thx in advance!

KihwaH commented 2 years ago

Hello! For my plugin it shouldn't be happening because it enforces NotoSans on its windows. I'll need to have a deeper look into this.

Do you select Axis to be used in dalamud? Also, which mod your friends are using? I want to see if I can port their fonts to Eglo.

Thx in advance!

Tested with both AXIS enabled and disabled on Dalamud. Both AXIS enabled and disabled affects the font of the translation box overlay, which might indicate font enforcement isn't working in my instance. I'll keep tinkering with the settings and see if anything changes.

Here's the mod: https://cdn.discordapp.com/attachments/361913574848724992/408914452768096256/fk.7z

This file isn't being maintained, just shared among Korean FFXIV communities. Just simply dropping it into game folder makes it work. Also since this file is from 2017, it uses font before 4K update.

lokinmodar commented 2 years ago

Hello! For my plugin it shouldn't be happening because it enforces NotoSans on its windows. I'll need to have a deeper look into this. Do you select Axis to be used in dalamud? Also, which mod your friends are using? I want to see if I can port their fonts to Eglo. Thx in advance!

Tested with both AXIS enabled and disabled on Dalamud. Both AXIS enabled and disabled affects the font of the translation box overlay, which might indicate font enforcement isn't working in my instance. I'll keep tinkering with the settings and see if anything changes.

Here's the mod: https://cdn.discordapp.com/attachments/361913574848724992/408914452768096256/fk.7z

This file isn't being maintained, just shared among Korean FFXIV communities. Just simply dropping it into game folder makes it work. Also since this file is from 2017, it uses font before 4K update.

I've found out the error with help of a fellow plugin dev friend. I'll release a fix for it <3

and thx for the font file. I'll look into it <3

KihwaH commented 2 years ago

I've found out the error with help of a fellow plugin dev friend. I'll release a fix for it <3

and thx for the font file. I'll look into it <3

Glad it helped!

lokinmodar commented 2 years ago

I've found out the error with help of a fellow plugin dev friend. I'll release a fix for it <3 and thx for the font file. I'll look into it <3

Glad it helped!

The update is waiting review and soon will be available when reloading the game through XL.

KihwaH commented 2 years ago

Hi, tested the new version. I can see Noto Sans is applied, but now I have this problem:

English: eng

Chinese Simplified: zh

Korean: han

Nepali: nep

Is this problem in just my case, or just CJK being a pain to deal with?

Also by the way ...\AppData\Roaming\XIVLauncher\installedPlugins\Echoglossian\2.99.2204.920\Font does not seem to contain CJK fonts if this can be the problem.

lokinmodar commented 2 years ago

Hi, tested the new version. I can see Noto Sans is applied, but now I have this problem:

English: eng

Chinese Simplified: zh

Korean: han

Nepali: nep

Is this problem in just my case, or just CJK being a pain to deal with?

Also by the way ...\AppData\Roaming\XIVLauncher\installedPlugins\Echoglossian\2.99.2204.920\Font does not seem to contain CJK fonts if this can be the problem.

Hello! Can you please delete the file ...\AppData\Roaming\XIVLauncher\pluginConfigs\Echoglossian.json and relaunch the game to see if it will download these CJK fonts? For some reason it did not download the fonts for you in background

KihwaH commented 2 years ago

Hello! Can you please delete the file ...\AppData\Roaming\XIVLauncher\pluginConfigs\Echoglossian.json and relaunch the game to see if it will download these CJK fonts? For some reason it did not download the fonts for you in background

After deleting that file Dalamud just removed the whole folder and I had to install Echoglossian again. After that fonts were still not downloaded and same problem occured. So I just tried downloading CJK fonts from Echoglossian/Font/ and putting in there and...

nice

Fixed.

By the way, those font files are huge. I expect most of them are same characters or include practically unused characters. Current Noto Sans KR file from Google is 4.5 MB for Regular size.

KihwaH commented 2 years ago

Extra stuff I found (pardon if there are duplicates):

lokinmodar commented 2 years ago

Extra stuff I found (pardon if there are duplicates):

  • Overlay font scale has negative values (when set to negative text gets just invisible) scale
  • These system messages get translated even when Translate in-game dialogues is off (these follow the font scale of in-game dialogs so I assumed this way. Tested with all 3 translate options off, only Activate game text realtime translation on) jump

Nice findings. I'll have to comb those options so they do not overlap or override each other. About the download it is weird that even deleting the config and reloading the game you still did not receive them. Do you have the XL folder added as an exception to your antivirus/windows defender? Also, can youu check if there is an echoglossian.db file in the pluginConfigs\Echoglossian folder?

lokinmodar commented 2 years ago

Extra stuff I found (pardon if there are duplicates):

  • Overlay font scale has negative values (when set to negative text gets just invisible) scale
  • These system messages get translated even when Translate in-game dialogues is off (these follow the font scale of in-game dialogs so I assumed this way. Tested with all 3 translate options off, only Activate game text realtime translation on) jump

Nice findings. I'll have to comb those options so they do not overlap or override each other. About the download it is weird that even deleting the config and reloading the game you still did not receive them. Do you have the XL folder added as an exception to your antivirus/windows defender? Also, can youu check if there is an echoglossian.db file in the pluginConfigs\Echoglossian folder?

The negative overlay font scale was a request of some players that wanted to set the overlay translation box to go away without disabling it (weird, i know)

KihwaH commented 2 years ago

Do you have the XL folder added as an exception to your antivirus/windows defender?

Oops! However Windows Defender hasn't been complaining about Dalamud at all so I wasn't thinking of that. I added it as an exception now.

I removed ...\AppData\Roaming\XIVLauncher\pluginConfigs\Echoglossian.json once again, which uninstalled the plugin, installed again, no CJK. 27 Font files. I added 5 CJK fonts so 32 were there.

Also, can youu check if there is an echoglossian.db file in the pluginConfigs\Echoglossian folder?

There is, slight peek via VS Code shows it's full of original and translated dialogues.

The negative overlay font scale was a request of some players that wanted to set the overlay translation box to go away without disabling it (weird, i know)

Yeah, I think there will be better ways to implement that...

KihwaH commented 2 years ago

I feel that you were in a hurry writing codes for this, take some time for your breath.

lokinmodar commented 2 years ago

I feel that you were in a hurry writing codes for this, take some time for your breath.

I certainly was. But the major rework i'm doing for the 3.0 version of the plugin will address many of the problems the 2.x version still has.

About the fonts not being downloaded, i'll provide a new mirror for them in the future becaus i think this is due to GitHub limitations and quotas...

KihwaH commented 2 years ago

About the fonts not being downloaded, i'll provide a new mirror for them in the future becaus i think this is due to GitHub limitations and quotas...

I haven't looked at your code yet, but may I suggest using reliable source like Debian repo? I don't know if TTC can be used in your plugin, but this one file contains all CJK region fonts including Mono and only 18MB in size.

lokinmodar commented 2 years ago

About the fonts not being downloaded, i'll provide a new mirror for them in the future becaus i think this is due to GitHub limitations and quotas...

I haven't looked at your code yet, but may I suggest using reliable source like Debian repo? I don't know if TTC can be used in your plugin, but this one file contains all CJK region fonts including Mono and only 18MB in size.

I'll look into it. ttc files are not supported by ImGui tho... I'll maybe need to extract the contents form them

lokinmodar commented 1 year ago

I'll close this for the moment. Dalamud in the main branch does not support other translations to the UI so well.