search

lokku / Perl-Critic-Lokku

A collection of Perl::Critic policies
https://metacpan.org/pod/Perl::Critic::Lokku
0 stars 4 forks source link

Fix exception when using try in a conditional #2

Closed bk2204 closed 7 years ago

bk2204 commented 7 years ago

This fixes #1.

Flimm commented 7 years ago

Thanks. I'm not a member of the Lokku organisation on GitHub any more, how would @lokku like to proceed? @kaoru @mtmail

kaoru commented 7 years ago

Sadly I'm no longer with Lokku and the company such as it exists now doesn't use Perl.

@bk2204 the change looks good to me! Can I suggest you fork Perl::Critic::Lokku it and release it to CPAN under a new name?

Maybe @Flimm (who still has ownership of the namespace on CPAN) could release a final version that adds a note in the docs that the module has been replaced by whatever you call yours.

Thanks!

bk2204 commented 7 years ago

This isn't terribly critical to me at the moment. We happened to trigger it because we had a mismatch between our lint tool and the version of perlcritic that it used, and it accidentally enabled this rule.

We do use the ProhibitExitingSubroutine rule, so it's possible I'll pick this up and release a new version to CPAN. I'll report back if I do.

Flimm commented 7 years ago

I've released a new version 0.003 on CPAN with this fix: https://metacpan.org/pod/Perl::Critic::Lokku

As I don't have access to this GitHub repo any more, I can't merge in the changes.

I've included a notice saying that the module is abandoned.

If anyone from @lokku would like to move Perl::Critic::Lokku to their PAUSE account, let me know.