search

loklak / loklak_python_api

The loklak API for Python which makes it very easy to use and as a strict replacement to the twitter API
1.09k stars 26 forks source link

Added count in the search function (old) #33

Closed gunvirranu closed 8 years ago

gunvirranu commented 8 years ago

I didn't know what else to implement at the moment. Now there is a count parameter that specifies how many tweets you want returned. Also added a test in sample.py and added documentation in the README. I don't know if this is useful, but take a look anyway. Thanks.

Btw, this is not a GCI task. Just interested in the project.

sudheesh001 commented 8 years ago

Please squash into a single commit ! Good work @gunvirranu Also update the documentation in README for the search()

gunvirranu commented 8 years ago

I already updated the documentation in the README. How do you squash them into a single commit?

gunvirranu commented 8 years ago

Could you just close this actually. I'd rather just do it again cause I accidentally messed up the commits in my fork trying to squash them. Unless you could help me fix this?

sudheesh001 commented 8 years ago

I hope this will solve the issue. https://asciinema.org/a/11269

sudheesh001 commented 8 years ago

Also don't forget after rebasing, you need to do a force push or it'll complain about pull before push. so add , -f at the end of your git push ..... statement

gunvirranu commented 8 years ago

Thanks. But I'm going to open another PR as I messed up my current fork by trying to squash the commits.

sudheesh001 commented 8 years ago

Tip: Always contribute using branches, never master !

gunvirranu commented 8 years ago

Thanks for the tip. I did use a branch, but I merged the branch with master and couldn't figure out how to squash the commits. That eventually led to a bunch of things messing up. I made a new PR if you didn't see btw.