Registering missing servelets in loklakserver.java

[jigyasa-grover]

It has been observed that many services which have been successfully implemented as console services are not registered individually in loklakserver.java

• [x] Github Profile Scraper
• [x] Wordpress Scraper
• [x] Instagram Scraper
• [x] RSS Reader
• [x] Event Brite Scraper
• [x] Wiki Geo Data Provider
• [x] Location Wise Time Provider
• [x] Time an Date Service
• [x] Meetups Scraper

[shivenmian]

Er, they are there on loklakserver.java. look closely

[jigyasa-grover]

@shivenmian Where to look closely ?

Edit: If you mean their classes were imported ? But their servlets were never added.

[shivenmian]

Check lines 490-526 and 535-593 in https://github.com/loklak/loklak_server/blob/development/src/org/loklak/LoklakServer.java. Servlets are registered here.

[jigyasa-grover]

@shivenmian I dont see any servletHandler.addServlet(..) for them

[shivenmian]

Check lines 527-532, they are added in a loop.

[jigyasa-grover]

Also, adding them in Class<? extends Servlet>[] services = new Class[]{...} is left, which I am pushing in the next commit.

[shivenmian]

No you're doing it wrong. That's not to be done. There are two ways of registering.

[jigyasa-grover]

@shivenmian

        for (Class<? extends Servlet> service: services)
            try {
                servletHandler.addServlet(service, ((APIHandler) (service.newInstance())).getAPIPath());
            } catch (InstantiationException | IllegalAccessException e) {
                e.printStackTrace();
            }

I get the point that they are being added in the loop. But I guess I need to add them in the list of services at least ?

[jigyasa-grover]

@shivenmian That's what I meant, rectifying in the next commit.

[shivenmian]

490-526 exactly is the list of services. Just add them there. The remaining five servlets.

[jigyasa-grover]

@shivenmian Got that already :) Thanks.

[jigyasa-grover]

@shivenmian A new PR has been opened https://github.com/loklak/loklak_server/pull/815/files