search

lokonli / slide-domoticz-local

GNU General Public License v3.0
2 stars 1 forks source link

Changes to the plugin #3

Closed heggink closed 3 months ago

heggink commented 3 months ago

Hey Sander,

I have geen using this for quite some time (years) but I think I made some changes. These are attached in case they are of use.

H

lokonli commented 3 months ago

I'm almost ready with the update. I'll publish a new version today.

heggink commented 3 months ago

Sounds good. As said, I have been on the attached changes for over 2 years without any issues.

lokonli commented 3 months ago

Can you attach your file? (it was not included in the first post)

heggink commented 3 months ago

also just emailed. something is messing up github :-(

lokonli commented 3 months ago

Probably I should have used your version as a starting point for the fixes ...

I see you also made it backwards compatible with older Domoticz versions. Nice! I will add that part of the code.

heggink commented 3 months ago

It was a bit of a hack. Not my best work haha

Kind regards, Herman Eggink Sent from mobile. Excuse any typos.

From: Lokonli @.> Sent: Sunday, May 19, 2024 5:19:19 PM To: lokonli/slide-domoticz-local @.> Cc: heggink @.>; State change @.> Subject: Re: [lokonli/slide-domoticz-local] Changes to the plugin (Issue #3)

Probably I should have used your version as a starting point for the fixes ...

I see you also made it backwards compatible with older Domoticz versions. Nice! I will add that part of the code.

— Reply to this email directly, view it on GitHubhttps://github.com/lokonli/slide-domoticz-local/issues/3#issuecomment-2119272996, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6NSF3MH45NDOZK65PS6STZDC7HPAVCNFSM6AAAAABH6HQJOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGI3TEOJZGY. You are receiving this because you modified the open/close state.Message ID: @.***>

lokonli commented 3 months ago

I've merged your changes (I think):

If I've missed something please let me know.