search

loktar00 / react-lazy-load

React component that renders children elements when they enter the viewport.
MIT License
979 stars 166 forks source link

Change debounce default value #121

Closed crisu83 closed 2 years ago

crisu83 commented 6 years ago

We use this library in our application which is available both on the web as well as on the mobile (as an app that is wrapped with Cordova).

Recently we stumbled on a nasty issue on mobile devices, which first seemed like a bug related to loading of images. It turned out that the issue was caused by the debounce feature in this library, which prevents images from being loaded while scrolling.

I would classify the debounce feature as a performance optimization and I don’t see any reason to perform any optimizations by default. Premature optimizations are usually considered bad practice as they may introduce unwanted side-effects.

That said I would like to suggest that this feature is turned off by default.

Thoughts?

OndeVai commented 5 years ago

Agreed. I was stumped for a while on this one, since even cached images were delayed from rendering.

loktar00 commented 2 years ago

Valid and noted, turning off in the newest version. https://github.com/loktar00/react-lazy-load/commit/3d2635bffdbf84515c2738b4a26e48999a23f381