Fix Issue #83: Issue with event firing on unmounted component.

loktar00 / react-lazy-load

React component that renders children elements when they enter the viewport.

MIT License

978 stars 166 forks source link

Fix Issue #83: Issue with event firing on unmounted component. #84

Closed nickpalmer closed 7 years ago

nickpalmer commented 7 years ago

This is a pretty terrible hack which resolves the problem I am seeing in issue #83. React considers this solution to be an anti-pattern. However, I don't see how to change the cleanup code to avoid the problem.

xavibonell commented 7 years ago

Any idea when this commit is gonna be merged with the base branch?

nickpalmer commented 7 years ago

I emailed the maintainer saying I would be happy to take over and he has never responded.

loktar00 commented 7 years ago

I died.

It is hacky but looks like some people need it so it's fine for a temp solution at the very least. Just been crazy busy with life/work :( haven't even made a pen in almost a year.

loktar00 commented 7 years ago

Thanks for the PR by the way!

srn commented 7 years ago

@loktar00 could you release a new version on npm? 😄

loktar00 commented 7 years ago

@srn done