lokyoung / vuejs-paginate

A Vue.js(v2.x+) component for creating pagination.
MIT License
778 stars 171 forks source link

Vue.js V3 support #128

Open bverheec opened 3 years ago

bverheec commented 3 years ago

Hello, I recently migrated my app to Vue.js v3 and the component wasn't working anymore. So I pulled the code source and here is what I changed to get it working:

In Paginate.vue:

<li v-for="page in pages" :class="[pageClass, page.selected ? activeClass : '', page.disabled ? disabledClass : '', page.breakView ? breakViewClass: '']"> Added v-bind:key="page.index" <li v-for="page in pages" v-bind:key="page.index" :class="[pageClass, page.selected ? activeClass : '', page.disabled ? disabledClass : '', page.breakView ? breakViewClass: '']">

<template v-for="page in pages"> <a v-if="page.breakView" :class="[pageLinkClass, breakViewLinkClass, page.disabled ? disabledClass : '']" tabindex="0"><slot name="breakViewContent">{{ breakViewText }}</slot></a> <a v-else-if="page.disabled" :class="[pageLinkClass, page.selected ? activeClass : '', disabledClass]" tabindex="0">{{ page.content }}</a> <a v-else @click="handlePageSelected(page.index + 1)" @keyup.enter="handlePageSelected(page.index + 1)" :class="[pageLinkClass, page.selected ? activeClass : '']" tabindex="0">{{ page.content }}</a> </template> Added v-bind:key="page.index" <template v-for="page in pages"> <a v-if="page.breakView" :key="page.index" :class="[pageLinkClass, breakViewLinkClass, page.disabled ? disabledClass : '']" tabindex="0"><slot name="breakViewContent">{{ breakViewText }}</slot></a> <a v-else-if="page.disabled" :key="page.index" :class="[pageLinkClass, page.selected ? activeClass : '', disabledClass]" tabindex="0">{{ page.content }}</a> <a v-else :key="page.index" @click="handlePageSelected(page.index + 1)" @keyup.enter="handlePageSelected(page.index + 1)" :class="[pageLinkClass, page.selected ? activeClass : '']" tabindex="0">{{ page.content }}</a> </template>

Then I updated the binding following this page [https://v3.vuejs.org/guide/migration/v-model.html#migration-strategy]()

value: { became modelValue: {

this.$emit('input', selected) became this.$emit('update:modelValue', selected)

In case someone else wants to migrate its application and wants to keep the same component.

ZtheLeader commented 3 years ago

@bverheec Create a PR for your fix :)

axel-verse commented 3 years ago

Still no V3 support?

secit-pl commented 3 years ago

Any update on this?

stevendprinsloo commented 1 year ago

This is by far one of the best Vue js paginate plugins, please can you look at getting Vue 3 support!

svifty7 commented 1 year ago

Hi there, I made a fork of the repository and updated it under Vue 3. I hope it helps in your applications. @svifty7/vue-paginate