lol768 / XenForo-MCASSOC

Minecraft association addon for XenForo
Other
20 stars 9 forks source link

Craftatart dropped username support #32

Open Luc1f3rUK opened 6 years ago

Luc1f3rUK commented 6 years ago

Craftatar has dropped username support for UUID only. https://crafatar.com/#meta-usernames

Please could you update the head image to use the UUID of the player?

Many thanks, Ryan

Jayson-Fong commented 6 years ago

Can you make sure that you're using the latest version of the add-on? I've modified the add-on to use UUIDs instead of usernames.

Regards, Jayson

Luc1f3rUK commented 6 years ago

Hi Jayson,

I'm using build 1.1.1 but can confirm that HeadImage.php is the same in both release and pre-release versions. Unless I'm missing a build but there's nothing newer in releases?

Thanks, Ryan

Luc1f3rUK commented 6 years ago

OK - so I've installed the latest repo changes and all seems to be working.

Are you planning to build and release a zip for the idiots like me?

Thanks, Ryan.

lol768 commented 6 years ago

Hey Ryan,

I merged but haven't gotten around to building a release yet :see_no_evil: - sorry! I've been on holiday this week, but will see what I can do to get this out within the next week.

Cheers.

Luc1f3rUK commented 6 years ago

Hey,

No problem haha!

If I could make a suggestion - what's your thoughts on adding a namemc account link when you click the username? Gives a nice page for skins etc. https://namemc.com/profile/cab734140d6045d5a645824a6552de31

I edited the template (association_thread_post) myself (ignoring the "mcblock" div as it adds CSS) and it's dirty but it works:

<xen:if is="{$mcNames.{$user.user_id}}!=null">
<div class="mcblock"><div class="mcAccInfoBlock">
<span class="mcAccHeading">Minecraft Accounts:</span>
<xen:foreach loop="{$mcEntries}" value="$entry">
<span class="mcAccText"><img src="{xen:helper headimage, $entry.minecraft_uuid, 11}" class="mcAccAvatar"></img> <a href="//namemc.com/{$entry.minecraft_uuid}" target="_blank">{$entry.last_username}</a></span>
</xen:foreach>
</div></div>
</xen:if>
Jayson-Fong commented 6 years ago

The add-on actually already has NameMC links for template association_thread_post. Make sure you're using the latest version of the XML file and that the template rebuild finished.

However, I will make a few tweaks to make it easier to edit.

Luc1f3rUK commented 6 years ago

Oh... I'm stupid.

Fair enough!

You guys should update the XenForo resources page! :)

Thanks again, Ryan

lol768 commented 6 years ago

I'd like to get #33 merged in and then release everything @Jayson-Fong has done in a release.

lol768 commented 6 years ago

@RyanMonkey and/or @Jayson-Fong can you test this build:

AssociationMc.zip