search

lol768 / XenForo-MCASSOC

Minecraft association addon for XenForo
Other
20 stars 9 forks source link

Change skin link is broken #35

Closed Malachiel87 closed 5 years ago

Malachiel87 commented 5 years ago

When i click "change skin" it redirect to this site: https://minecraft.net/en-us/login/?return_url=https%3A%2F%2Fminecraft.net%2Fen-us%2Fprofile%2Fskin%2Fremote%3Furl%3Dhttps%253A%252F%252Fwww.googleapis.com%252Fdownload%252Fstorage%252Fv1%252Fb%252Fmcassoc-ng.appspot.com%252Fo%252Fc883f59d66214243b64b3781d9fd9530.png%253Fgeneration%253D1551546432043876%2526alt%253Dmedia

and say 502 bad gateway

lol768 commented 5 years ago

This is part of lukegb/mcassoc rather than this add-on:

https://github.com/lukegb/mcassoc/blob/45c829c4616bf326678cfaf7958142574fde8d83/templates/perform.html#L206

But it sounds like a Mojang issue

lol768 commented 5 years ago

Potentially fixed in: https://github.com/lukegb/mcassoc/commit/a1820d72b692307bef222bb901fd79887c38c7ae

Malachiel87 commented 5 years ago

oh sorry i posted the issue in the wrong place, anyway that fix is live?

lol768 commented 5 years ago

I've sent Luke a twitter DM to ask him if he can push my fix to produciton

lol768 commented 5 years ago

@xion87 Can you reproduce now?

Malachiel87 commented 5 years ago

yeah seem fixed time ago sorry for missed the ticket ^^