search

loldevs / leaguespec

community crafted knowledge base around Riot Games observer system
Other
149 stars 17 forks source link

Use of wiki instead of files #1

Closed Zero3 closed 10 years ago

Zero3 commented 10 years ago

I like the stuff you compiled into https://github.com/loldevs/leaguespec/blob/master/doc/rest-service.md. However, this kind of information seems more suitable for the wiki functionality of Github. It would also allow for easier collaboration between the people interested - assuming that was your intent.

Maybe you would consider moving the info to the wiki?

themasch commented 10 years ago

I had the same idea. Will do it soon™

ghost commented 10 years ago

Hi I read what you wronte on this page, and there is something I would like to add. Last August, when I tried to analyze the data (maybe it has changed since), I noticed that, when I start spectating a game let's say after 10min of play, I can't replay the first part of the game. Moreover, if, for instance, I tried to download chunks number 1 or 2, I get http404 ...

Moreover, I noticed that the first available keyframe/chunk was corresponding to the time when I called the RTMP Api to get the activeGameInfo for one of the player in the game (to grab the password of the game). So, I guess that, to save bandwith, they upload the spectator data (which seem to be on Amazon) only when someone does request to the active game API .

Thus, to get the whole game data, you have to do a request to the API at the very beginning of the game. (for highlighted matches, it seems that they upload the data at the start of the game though)

2014-02-02 Mark Schmale notifications@github.com:

I had the same idea. Will do it soon(tm)

Reply to this email directly or view it on GitHubhttps://github.com/loldevs/leaguespec/issues/1#issuecomment-33908684 .

themasch commented 10 years ago

The server seems to throw away chunks that are to old. So if you start observing to late, you cant get back to that point in the past. I'm pretty sure @tyscorp can tell you a lot more about who the rest service works.

Divi commented 10 years ago

@trebonius2 @themasch Chunks are not available after ~10 minutes (+/- 1 minute) and even if nobody calls the RTMP API. The REST api chunk (getLastChunkData or Info) will give you the available chunk one minute ago (so two chunks before the current time) but more chunks are available. For featured game, chunks are saved more longer (15/20 minutes I guess, I not sure, but i'm 100% sure for normal game).

Keyframes are available immediately after the game starts (without waiting the 3 minutes spectator mode) if I remember.

themasch commented 10 years ago

Keyframes are available immediately after the game starts (without waiting the 3 minutes spectator mode) if I remember.

Whooot? Rly? That would be totally broken. Will test this ASAP.

tyscorp commented 10 years ago

https://github.com/loldevs/leaguespec/wiki/Keyframe-Specification

themasch commented 10 years ago

here we go: https://github.com/loldevs/leaguespec/wiki/REST-Service

Divi commented 10 years ago

@themasch no i'm sorry (it was late for me), it was "chunks" not keyframes. The loading chunks are available after the game starts. Usually 4/6 chunks.