search

loldevs / leaguespec

community crafted knowledge base around Riot Games observer system
Other
149 stars 18 forks source link

Error in documented keyframe player segment header #19

Closed Zero3 closed 10 years ago

Zero3 commented 10 years ago

https://github.com/loldevs/leaguespec/wiki/Keyframe-Player-Segment claims the following:

There are many possible sequences for the beginning of the header.

!! !! C3 !! 11 00 [00 00 00]

Note: when the #1 marker is 0x93, there is three more 0x00 at the end, example : 93 01 C3 4B 11 00 00 00 00

The 0x11 as byte 5 appears to be wrong. I have a keyframe which starts the first player segment header at the following 16 bytes:

0xb3 0x0 0xc3 0x4b 0x0 0x19 0x0 0x0 0x40 0x8 0x0 0x0 0x0 0x40 0x1b 0x1

The 0x11 was introduced in this edit. is the 0x11 a mistake @Divi?

Divi commented 10 years ago

Yes sorry, maybe a wrong copy/paste. I'll edit this, thanks :+1: I also found that the first marker can be 0xF4 or 0x44, but it appears in only 1 per 100 games and for only one player, I don't know why.