loldevs / leaguespec

community crafted knowledge base around Riot Games observer system
Other
149 stars 18 forks source link

Another error in documented keyframe player segment header #20

Closed Zero3 closed 10 years ago

Zero3 commented 10 years ago

https://github.com/loldevs/leaguespec/wiki/Keyframe-Player-Segment claims the following:


[...] followed by the rest of the header. (the structure of this is consistent)

++ ++ ++ 40                 // Entity ID
!! 00 00 00                 // Player number
40 00 XX 00
XX FF XX 00
00 00

The 0x00 as byte 5 after the player number (just after the 0x40) appears to be wrong. I have a keyframe containing the following 13 bytes after the player number:

0x00 0x00 0x00 0x40 0x1B 0x01 0x00 0xA4 0xFF 0x02 0x00 0x00 0x00

themasch commented 10 years ago

yeah, most of this is just guessed or "not seen something else, so this might be it". Go ahead and change it if you've seen other variants ;)

Divi commented 10 years ago

Like said @themasch, most of these bytes are not static. See #15. I'll update the wiki with dynamic and static parts when I have more time (maybe at the end of the next week).

Zero3 commented 10 years ago

Alright, I blanked out the relevant byte with 'XX' in the specs :).

Divi commented 10 years ago

Thanks !