loldevs / leaguespec

community crafted knowledge base around Riot Games observer system
Other
149 stars 18 forks source link

Summoner Name charset not documented in keyframe specification #21

Closed Zero3 closed 10 years ago

Zero3 commented 10 years ago

https://github.com/loldevs/leaguespec/wiki/Keyframe-Player-Segment#summoner-name should specify a charset.

Zero3 commented 10 years ago

It appears to be some Latin1 variant. (EDIT: But what about localized names on non-western servers?)

avborhanian commented 10 years ago

Just tried using the Korean server spectate rest service, and looking at the names, it looks like the charset used is UTF-8, which would be backwards compatible with ASCII. It's probably UTF-8 throughout.

themasch commented 10 years ago

i'm pretty sure its UTF-8. Checked that months ago when I wrote the first docs, and I was pretty sure its UTF-8. Can't remember why I didn't wrote it down. Maybe there have been some non-utf8 chars?

jaagupkymmel commented 10 years ago

Seems to be UTF-8. Closing the issue for now, reopen this or open a new one if there is evidence to suggest that this is not the case.