search

loldevs / leaguespec

community crafted knowledge base around Riot Games observer system
Other
149 stars 18 forks source link

Length of the summoners name field #5

Open themasch opened 10 years ago

themasch commented 10 years ago

I'm pretty sure that the length of the "Sommoner name" field is more then 16 bytes. I inspected some south-korean games and found names like this:

역시상호는윤상호 (24 bytes) 수지너무너무이뻐 (24 bytes) 유리멘탈 멘병이 (22 bytes)

Since these are 8 (resp. 7) characters in length, it should be possible to see at least twice as much bytes. For that reason I really think the summoners name field contains at least 48 bytes. There is unknown room after the field that allows it to take 128byte in total.

jaagupkymmel commented 10 years ago

Although this is probably correct and applies to turrets aswell, I think we should leave it as separated from name string, just in case.

themasch commented 10 years ago

I added a comment so we don't forget it ;-) would like to let this issue open until we know things for sure though

Theoretical commented 10 years ago

On the actual client names are std::string under full optimization so I'm not sure how they have them setup here.

tyscorp commented 10 years ago

Apparently there "may" be a flag to change the name length, depending on charset. Not sure though.