loldevs / riotapi

A general purpose api for all things riot
loldevs.github.io
Apache License 2.0
48 stars 14 forks source link

javax.net.ssl.SSLHandshakeException when connecting to some regions #28

Closed MaxiBoether closed 10 years ago

MaxiBoether commented 10 years ago

Hello,

whenever I try to connect to the following regions: BR, LAN, LAS, TR, OCE, RU I get an javax.net.ssl.SSLHandshakeException. Here is the complete stacktrace: http://pastebin.com/FYwnPtsB Connecting to EUW, NA and EUNE works. This is my java code: http://pastebin.com/1qJfemid

Sincerely, Mayesters

strangeglyph commented 10 years ago

This makes me thing that the problem is with the region's certificates:

> openssl s_client -showcerts -connect prod.br.lol.riotgames.com:2099
CONNECTED(00000003)
depth=0 /C=US/ST=California/L=Santa Monica/O=Riot Games Inc/CN=*.br.lol.riotgames.com
verify error:num=20:unable to get local issuer certificate
verify return:1
depth=0 /C=US/ST=California/L=Santa Monica/O=Riot Games Inc/CN=*.br.lol.riotgames.com
verify error:num=27:certificate not trusted
verify return:1
depth=0 /C=US/ST=California/L=Santa Monica/O=Riot Games Inc/CN=*.br.lol.riotgames.com
verify error:num=21:unable to verify the first certificate
verify return:1
---

I'll look into it, but I guess we are going to need a dummy verifier

MaxiBoether commented 10 years ago

Ok, nice, so you will be able to fix the problem? Or can I help you in some way?

Am 22.09.2014 um 05:19 schrieb Boreeas notifications@github.com:

This makes me thing that the problem is with the region's certificates:

openssl sclient -showcerts -connect prod.br.lol.riotgames.com:2099 CONNECTED(00000003) depth=0 /C=US/ST=California/L=Santa Monica/O=Riot Games Inc/CN=.br.lol.riotgames.com verify error:num=20:unable to get local issuer certificate verify return:1 depth=0 /C=US/ST=California/L=Santa Monica/O=Riot Games Inc/CN=_.br.lol.riotgames.com verify error:num=27:certificate not trusted verify return:1 depth=0 /C=US/ST=California/L=Santa Monica/O=Riot Games Inc/CN=*.br.lol.riotgames.com verify error:num=21:unable to verify the first certificate

verify return:1

I'll look into it, but I guess we are going to need a dummy verifier

— Reply to this email directly or view it on GitHub.

strangeglyph commented 10 years ago

It should be easy to fix, I'll probably just take Jabe's version of DummySSLSocketFactory

MaxiBoether commented 10 years ago

I think after all, this is just pointless: https://developer.riotgames.com/discussion/riot-games-api/show/oklxAP21 https://developer.riotgames.com/discussion/riot-games-api/show/nXBIH6ZL

We aren't allowed to use RTMP anymore etc. (except the spectator things) So basically it's just useless.

strangeglyph commented 10 years ago

Yeah, that's been announced a couple of weeks ago. I plan on keeping riotapi updated as long as possible though.