search

loldevs / riotapi

A general purpose api for all things riot
loldevs.github.io
Apache License 2.0
48 stars 14 forks source link

Issue connecting to NA using XMPP #49

Closed pip8786 closed 8 years ago

pip8786 commented 8 years ago

I tried the example listed here to connect to NA servers using my regular username/password but I get an exception.. It seems to work OK when connecting to EUW. Any idea what could be going wrong?

I've tried this with 2.0.6 and 2.0.4 from Maven.

pip8786 commented 8 years ago

I figured it out. Line 255 of Shard.java has an incorrect property. It looks for "xmpp_server" when the properties files actually have "xmpp_server_url" in them. I imagine it works for the other server because the default is still OK.

I will try to get a pull request together though I've never done that before.