lole-elol / tum_cv_challenge_SS23

2 stars 2 forks source link

Feat gui #32

Closed SamiNoelAzizHanna closed 1 year ago

SamiNoelAzizHanna commented 1 year ago
Screenshot 2023-06-29 at 11 07 06 Screenshot 2023-06-29 at 11 06 17
lole-elol commented 1 year ago

Looks pretty good. Is there a reason for the orange background?

I'm a little bit confused about the changes in +logic/extractCommonFeatures.m and +logic/preprocessImage.m. This might be a merging error because as far as I know those files where moved to +logic/reconstruct3d/

Yea this could be the case, I wasn't sure if the files are to be deleted since they weren't marked as deprecated. So in order not to accidentally loose some work I keep them.

SamiNoelAzizHanna commented 1 year ago

Looks pretty good. Is there a reason for the orange background?

I'm a little bit confused about the changes in +logic/extractCommonFeatures.m and +logic/preprocessImage.m. This might be a merging error because as far as I know those files where moved to +logic/reconstruct3d/

No particular reason, for the designs, we would have to sit down together anyway. This is just to showcase our options, also the buttons.

SamiNoelAzizHanna commented 1 year ago

New function inside GUI: plotRoom: plots pointcloud, cuboids and planes into GUI Figure. Screenshot shows all functions combined. Preview images do not have anything to do with the room plot (yet). They just show a selection of the UserUpload. Room plot shows data from poits3d_massaged (test file in validation->relief2).

Problems:

Screenshot 2023-06-30 at 14 57 21
danielsanjosepro commented 1 year ago

New function inside GUI: plotRoom: plots pointcloud, cuboids and planes into GUI Figure. Screenshot shows all functions combined. Preview images do not have anything to do with the room plot (yet). They just show a selection of the UserUpload. Room plot shows data from poits3d_massaged (test file in validation->relief2).

Problems:

  • pcshow deletes old plots (cuboids,...) even when using hold on
  • when using pcshow first (such that it does not delete the other plots), the camera view is really far away from the cuboids and basically only shows the floor and ceiling plane stretching into -inf/ inf -> did you experience similar problems?
  • strangly plot and pcshow worked just fin

Sexy. looks good.

danielsanjosepro commented 1 year ago

Could you provide a small guide as well? So that I can test it as well (like a Gui.md or so)