Benchmarking functions for 3D reconstruction

lole-elol / tum_cv_challenge_SS23

2 stars 2 forks source link

Benchmarking functions for 3D reconstruction #33

Closed danielsanjosepro closed 1 year ago

danielsanjosepro commented 1 year ago

[x] Create script to generate .mat files for 3D reconstruction
[x] Implement run func for 3D reconstruction
[x] Implement display func for 3D reconstruction
[x] Make detection benchmarking compatible with reconstruction
[ ] Archive reconstruct3D for 2 images, only do multiview
[x] Test a bit

Closes #34 Closes #31

danielsanjosepro commented 1 year ago

Running tests for 3D reconstruction:

Displaying 3D reconstruction results:

danielsanjosepro commented 1 year ago

@lufixSch @lole-elol the benchmarking part is ready. Do you like it like this? Try out some of the commands in Benchmarking.md

lole-elol commented 1 year ago

Looks really nice. In the 3D reconstruction results you posted above, are pc1 and pc2 the same scene or tow different scenes?

lufixSch commented 1 year ago

Looks good. I like the feature that you added where you can enter multiple data paths.

I have some Remarks:

[x] Why did you add a second file for reconstruction benchmark configs? I consciously saved all detection params in the config file in the detection variable so that you could add a reconstruction variable for the 3d reconstruction benchmarks
[x] Same goes for the data creation
[x] I don't know if it is necessary to print all parameter combinations as this might get pretty long when increasing the number of parameters

lufixSch commented 1 year ago

[x] While testing I saw that the numImages is still set to 3

lufixSch commented 1 year ago

I also added rotation of the point cloud. Now the z-Axis should be the height axis.

I was not able to rotate the Cameras correctly. Among other things because it is really hard to tell where they should be.

danielsanjosepro commented 1 year ago

@lole-elol pc1 and pc2 are two scenes @lufixSch I will make some changes tomorrow then

danielsanjosepro commented 1 year ago

Closes #34 , #31

danielsanjosepro commented 1 year ago

I also added rotation of the point cloud. Now the z-Axis should be the height axis.

I was not able to rotate the Cameras correctly. Among other things because it is really hard to tell where they should be.

Did that

danielsanjosepro commented 1 year ago

I will merge this tomorrow morning, I almost finished the requests of Lukas.

danielsanjosepro commented 1 year ago

@lufixSch

Everything is now created in one file and one config.mat
Only logging the first 10 elements of the table (so that it doesnt "explode" with a long logging haha)
Num of images is now per default Inf (it is a parameter, otherwise my laptop cant handle alll the images)

Merging now, I think it is fine as it is, otherwise we will change it later