Stop using deprecated scipy namespaces

loli / medpy

Medical image processing in Python

http://loli.github.io/medpy/

GNU General Public License v3.0

559 stars 136 forks source link

Stop using deprecated scipy namespaces #112

Closed nicolascedilnik closed 1 year ago

nicolascedilnik commented 1 year ago

A certain number of scipy.ndimage namespaces are deprecated, this PR ensures future-proofness.

nicolascedilnik commented 1 year ago

Thanks for the prompt review. The reason I had not changed the others is because I missed them (they are in scripts I don't use), but I agree, it's worth changing too, hence my force push.

About the private functions, I would not touch them, but I guess it would be better not to import anything private. Now I guess you had good reasons for importing them, but I would say that is a different issue?

loli commented 1 year ago

You are quite right about the private function. That's a matter for another issue. Thank you again!