Closed cancan101 closed 6 years ago
Apparently, using spaces in dictionary keys is absolutely valid, as discussed in https://stackoverflow.com/questions/13474957/spaces-in-python-dictionary-keys. But I can see your point that it becomes inconvenient in this case.
On the other hand, the itk
package can't be installed via pip. Please see the documentation (https://loli.github.io/medpy/) for detailed instructions on how to compile ITK with Python wrappers.
I wasn't referring to spaces in dictionary keys in general, I was specifically referring to extra requires. Also I think there is now a wheel for itk so I think It can be pip installed.
You're right, that's amazing. Thank you for pointing this out to me!
https://blog.kitware.com/itk-is-on-pypi-pip-install-itk-is-here/
Did you already tried if the medpy
IO with that version of ITK?
Ok given that people probably were not using that extra (and that It didn't work until recently) what do you think about renaming it to all
or extra_formats
or itk
?
I would go with extra_formats
, since that's the sole purpose of the itk
module in MedPy. If you want, you can make the adjustment and create a pull request. Otherwise I'll fix it when I get around to it.
Right now the
extras_require
is:which contains a space in the key, something I have never seen before. This causes problems when trying to pip install. Perhaps there is a way to escape, but this seems non intuitive:
I suggest offering a string without a space.