search

lolmaus / breakpoint-slicer

Slice media queries with ease
https://lolmaus.github.io/breakpoint-slicer/
346 stars 28 forks source link

Eyeglass support #17

Open polarathene opened 9 years ago

polarathene commented 9 years ago

Any chance of providing support for Eyeglass? It's a JS equivalent to Compass from what I understand. The support would make it possible to use Breakpoint Slicer via LibSass on Node.js I think?

Details on how to support Eyeglass is here: https://github.com/sass-eyeglass/eyeglass/blob/master/docs/eyeglass_modules/index.md#bringing-eyeglass-to-existing-projects

ManasN commented 9 years ago

I am counting on support for Eyeglass too :) thanks.

lolmaus commented 8 years ago

Hi.

I've published the project on npm and created an Eyeglass config. I'm not using Eyeglass yet, so I dunno if the config is correct.

Can you please try installing and using it via Eyeglass?

stevetweeddale commented 8 years ago

Yeah, it doesn't work :(

It appears that for some reason going via eyeglass causes node-sass to choke on the indented syntax you use. Looking around, this issue looks like it might be it: https://github.com/sass/node-sass/issues/1192

stevetweeddale commented 8 years ago

I've just whipped up a quick fork that sidesteps the issue by converting to the scss bracketed syntax.

I don't care much for the older syntax, but I know people sometimes feel strongly about such things. So I can make it a pull request if you'd like to exchange indented sass syntax for working eyeglass support! Otherwise, once that issue is fixed you should be golden.

The other change I made was addressing the following complaint made by eyeglass on compilation:

The following modules did not declare an eyeglass version:
  breakpoint-slicer
Please add the following to the module's package.json:
  "eyeglass": { "needs": "^0.8.3" }
lolmaus commented 8 years ago

This sucks. :( All those curlies and semicolons do not bring any benefit, only visual noise.

OK, I'll accept a PR.

lolmaus commented 3 years ago

I'm sorry for neglecting this.

I have rewritten Breakpoint Slicer from scratch with support for Sass modules.

Please tell me if it works with Eyeglass. If it doesn't, please file a PR and I promise I'll tackle it within a week.