search

lolmaus / ember-cli-stained-by-children

Ember CLI addon: a mixin that makes the `isDirty` property of a record respect the dirtiness of its belongsTo/hasMany children
MIT License
25 stars 6 forks source link

Updated to work with latest ember-data #15

Closed seanrucker closed 8 years ago

seanrucker commented 9 years ago

This will resolve #14 and add support for the latest version of ED.

lolmaus commented 9 years ago

Thank you, I will have a look at it soon.

seanrucker commented 9 years ago

How do I run the tests? npm test doesn't run anything.

lolmaus commented 9 years ago

Either ember test, or run ember s as you would normally, then access http://localhost:4200/tests/ .

seanrucker commented 9 years ago

I started working on updating the tests but ended up going down a rabbit hole...

Requires updating ember-data which requires updating ember-cli which requires removing dependencies on prototype extensions...etc.

Additionally the payload for the test data needs to change, the template files throw all kinds of deprecation warnings.

I gave it an hour but unfortunately I need to move on to some other stuff. Might have time to work on this again next week.

kmiyashiro commented 9 years ago

I'm interested in getting this done, @seanrucker are you still working on it?

lolmaus commented 9 years ago

It's probably easier to restart from scratch. I. e. use an orphan branch.

But I don't have motivation to work on this addon unless there is a known way to mark a parent record as dirty when a relationship is changed.

kmiyashiro commented 9 years ago

:crying_cat_face: