CleanEmbeddedChildrenMixin should propagate rollback

lolmaus / ember-cli-stained-by-children

Ember CLI addon: a mixin that makes the `isDirty` property of a record respect the dirtiness of its belongsTo/hasMany children

MIT License

25 stars 6 forks source link

CleanEmbeddedChildrenMixin should propagate rollback #3

Closed agebhar1 closed 9 years ago

agebhar1 commented 9 years ago

Hi,

currently in case of canceling modification on either the root record or one of its embedded childs (records) by record.rollback() does not propagate the call to its dependencies. Hence a modified child will stuck on child.get('isDirty') and also its owner/root record even rollback was called on root. For symmetry CleanEmbeddedChildrenMixin should also propagate rollback next to save.

lolmaus commented 9 years ago

Closed in #4 by @agebhar1.