search

lolmaus / ember-cli-stained-by-children

Ember CLI addon: a mixin that makes the `isDirty` property of a record respect the dirtiness of its belongsTo/hasMany children
MIT License
25 stars 6 forks source link

Ember v1.12.0 Support #6

Closed jmurphyau closed 9 years ago

jmurphyau commented 9 years ago

In Ember v1.12.0 you can no longer redefine isDirty directly so a new field isFilty has been created.

The isDirty field can still be defined using Ember.defineProperty so for backwards compat. this has been done with a deprecation warning added.

As a temporary workaround for anyone viewing this pull request - I've implemented a 'v0.4.0-ember1.12.0-workaround' tag on my fork which can be used to resolve the issues when using the canary branch.

To use this you can change your package.json file from:

"ember-cli-stained-by-children": "0.4.0"

to:

"ember-cli-stained-by-children": "git://github.com/jmurphyau/ember-cli-stained-by-children.git#v0.4.0-ember1.12.0-workaround"

jmurphyau commented 9 years ago

So I may have jumped ahead of myself

There is now another commit that removes isDirty as a reserved property..

https://github.com/emberjs/data/pull/2921