Closed Swahvay closed 6 months ago
for 2, looks like i decided to go from the other direction since it would have been a 1/1 mapping in the case of the fieldEdge and foreignKey?
probably because i didn't think it was worth it, not sure?
for 1/, fixed in https://github.com/lolopinto/ent/pull/1800
non-base classes would have to be fixed manually.
I just realized I completely misunderstood #2. 🤦🏿♂️
for 1/, fixed in https://github.com/lolopinto/ent/pull/1800
non-base classes would have to be fixed manually.
No problem! Thanks for getting to this. 🙂
Two minor things.
1) The mixin interface doesn't default to the Viewer specified in
ent.yml
:should be
(The base should also be
ISomePatternBase<TViewer extends MyCustomViewer = MyCustomViewer>
.)2) Field edges and foreign keys loaders do not get defined on pattern interfaces. Edges defined on the pattern generate
queryFoo
interfaces correctly, butfieldEdge
s orforeignKey
s defined on a field in a pattern do not generate theloadFoo
orqueryFoo
method definitions on the interface.