lolouk44 / hassio-addons

Xiaomi Mi Scale Add On for Home Assistant
MIT License
126 stars 42 forks source link

Add weight device_class to weight sensor #76

Open kaizersoje opened 1 year ago

kaizersoje commented 1 year ago

Select Add-On (place a lowercase x for the relevant add-on)

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen. New weight device class has been added in HA Core 2023.1.x. URL Could you add this device_class to the weight sensors?

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

lolouk44 commented 1 year ago

Thanks. I'll probably wait a bit as this would be a breaking change, forcing all users to upgrade HA.

I'll keep this open in the meantime

kaizersoje commented 1 year ago

Sorry, my bad. It was added in 2022.10 change

All changes in 2022.10

lolouk44 commented 1 year ago

Hey @kaizersoje, I looked into this again and I'm not sure what the benefits would be. Regardless you can add this yourself to your sensor config if manually configured. If using MQTT Auto-Discovery I'll look at it.