lolp1 / Overlay.NET

An easy-to-use overlay library written in C# by Jacob Kemple.
730 stars 87 forks source link

BUG DirectX Overlay showing when window is not focused #3

Closed Traderain closed 7 years ago

lolp1 commented 7 years ago

Confirmed bug, will look to fixing it in the next day or so.

Traderain commented 7 years ago

When can this be expected to be fixed?

lolp1 commented 7 years ago

@Traderain

The bug is now fixed in the demo. Build the .sln and you should be set.

Traderain commented 7 years ago

Thank you

lolp1 commented 7 years ago

@Traderain No problem. Please feel free to report any more bugs or if this bug is not fixed for you.

Traderain commented 7 years ago

image Win7 vs15 nothing changed in the code


(ps.: works with the wpf overlay perfectly)

lolp1 commented 7 years ago

@Traderain Can you please try cleaning, then rebuilding the soultion, then placing ../debug contents from Overlay.NETs debug folder inside of the demos debug folder, then ensure one note pad is open only, and try again.

Traderain commented 7 years ago

@lolp1 Did that still the same result

lolp1 commented 7 years ago

@Traderain

Seems to be working for me on the latest build. Details of how I did the actions in the video comments.

https://www.youtube.com/watch?v=8Vv4s_ndV2Y&feature=youtu.be

Traderain commented 7 years ago

Thats exactly what I did. I will try to troubleshoot it and report here if I can fix it so others know about it.

lolp1 commented 7 years ago

@Traderain
Do you use x86 or x64 based pc?

Traderain commented 7 years ago

x64

lolp1 commented 7 years ago

@Traderain Can you please try either 1. Compile with the option "prefer 32 bit" or 2. Try the overlay on a process you can ensure is a x64 process. I'd go with 1 and try it on notepad, as it is a x86 process despite the OS being x64 you use.

It is possible that is an issue with my Process.NET library not reading the window status correctly in a 32 bit process on a x64 OS if 32 bit is not preferred.

Traderain commented 7 years ago

@lolp1 Tried it on my laptop which is Winows 10 and it works perfectly. Here is a snapshot of the details of my PC so you can troubleshoot the issue better. image

lolp1 commented 7 years ago

Thanks for the report I'll look into it. The project was built with the latest libraries and .net frameworks in the latest visual studio, so it is possible there are some bugs in windows 7 I need to track down. I'll see what I can find.

Traderain commented 7 years ago

Have you managed to come up with a fix? Sadly I can't switch my project's overlay library until this is fixed because I have many win7 users.

toomtoomcheck commented 7 years ago

Hi,

Same issue here, If you reduce the windows it works perfectly, but if you switch windows without reducing it, it's still showing me overlay.

Regards

lolp1 commented 7 years ago

@Traderain @toomtoomcheck Free time is on my side for a while (hopefully a long while!). I will be looking into the issue today and trying to fix. I will update my findings soon here.

mattukdev commented 7 years ago

I also have this same issue on win 7 x64.

also using an AMD card if that helps.

MakariAeron commented 7 years ago

I've got the same problem too with Win7, Nvidia Quadro card here. I think it's something to do with how Win7 shows things. It's a shame because Win7 is still so widely used. I guess I'll stick with WPF for now.

lolp1 commented 7 years ago

As far as I can tell, this bug does not exist in windows 10 and the only windows 7 device I have access to can not reproduce it. I am going to close the issue for now (as I am going through and cleaning them up) as I only intend to support windows 10+ from this point on.

However, this does not mean I am not interested in fixing the bug. If it still exist on the latest version just committed, and you can provide more details, such as what happens while stepping through in debugger or any suspicious stacktraces, or any kind of fix, I will look into it/implement it/accept any pull request. Thanks