search

lombardpress / lombardpress-schema

0 stars 2 forks source link

Bugfix/proofs to the 1.0.0 documentation #105

Closed stenskjaer closed 7 years ago

stenskjaer commented 7 years ago

From the commit messages:

Proofs to critical.md: A few of these corrections may be a matter of dispute, so I would recommend looking through them.

Proofs to diplomatic.md: Note that I am uncertain whether you can actually say "... mark places that an ...". Here where seems more natural to me, but I may be wrong. In that case, those hunks should be removed.

Generally: When merging these should/could be squashed into one commit.

jeffreycwitt commented 7 years ago

Looks good. I noticed that you changed all sigla to italics. That's fine by me as along as we're consistent. I noticed a few "A" that were not changed to italic. (Actually changed from italic, to non-italic). If you don't mind correcting these and as well as the above corrections, then I pull this in.

stenskjaer commented 7 years ago

The italics is a complicated case. I switched back and forth, and then unfortunately ended somwhere in the middle (it wasn't consistent before either). Actually I had an evil plan about changing all to non-italic (and made a long commit message about it for a separate commit), as that's what I prefer. But then I had already made all (supposedly) italic and decided to keep it at that. But if you prefer non-italic, I would happily oblige. Otherwise I will make sure that they are all actually italic rather than just almost all.

stenskjaer commented 7 years ago

I have added the suggested changes.