lombardpress / lombardpress-webjs

0 stars 3 forks source link

Ref targets in diplomatic transcriptions aren't triggering show reference view #64

Closed jeffreycwitt closed 3 years ago

jeffreycwitt commented 3 years ago

Ref targets in diplomatic transcriptions aren't triggering show reference view.

I think this is due to "incompleteness" in the xslt script and the ref target is not getting transferred to the presentation html

jeffreycwitt commented 3 years ago

The source of the error is here: https://github.com/scta/scta-app/blob/3523d6c59db7d01fb2eaf011ef3a622b70084d91/xslt-lbpwebjs-main.xsl#L221; the selector is pointed at ./target instead of ./@target;

It needs to be fixed here: https://github.com/scta/scta-app/blob/3523d6c59db7d01fb2eaf011ef3a622b70084d91/xslt-lbpwebjs-main.xsl#L221 and https://github.com/lombardpress/lombardpress-webjs/blob/820ebc6e2567b839f183dbc8d10efb594d76440e/public/xslt/main_view.xsl#L196 

jeffreycwitt commented 3 years ago

resolved with commit 5f75c1372b734dc90dc515c52c230d5b1e653dd9 and adjustments to commit b9c48c0442a67ce28a2a1767923f7af5678e762b in scta/scta-app and manual adjustment to production version in existdb