lombardpress / lombardpress-webjs

0 stars 3 forks source link

target with word range, should be better reflect at expression level in side panel #90

Closed jeffreycwitt closed 3 years ago

jeffreycwitt commented 3 years ago

target with word range, should be better reflect at expression level in side panel

The difficulty here is dealing with parallels between manifestations.

highlighting a text range on a non canonical manifestations, does not necessarily mean your are point at the same range in another manifestations. (Though in most cases it will be roughly correct).

Maybe expression wordRange should only be included if you are selecting the canonicalManifestation???

And if highlighting a non-canonicalManifestation, the range can be added to the expression, but with some sort of "hint" that notes that this is only a rough approximation.

Path:      /text?resourceid=http://scta.info/resource/jdso8u-d1e1293-d1e191/cod-u78xV9/transcription@2-8
Browser:   Chrome 91.0.4472.114 on Mac OS 10.15.7
Viewport:  1920 x 791 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Submitted from Netlify Deploy Preview #83

jeffreycwitt commented 3 years ago

see commit https://github.com/lombardpress/lombardpress-webjs/commit/bf6356d59b07338d9cdeddced4790cc85c223c48