search

lona-web-org / lona

Write responsive web apps in full python
MIT License
528 stars 28 forks source link

views: issue warning on use of .daemonize #458

Closed AvdN closed 8 months ago

AvdN commented 1 year ago

add deprecation warning add intermediary Lona_2_0_DeprecationWarning so only one warnings needs to be set for filtering. update example code

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (68b0445) 73.16% compared to head (e325229) 71.81%. Report is 20 commits behind head on master.

:exclamation: Current head e325229 differs from pull request most recent head 0ff6921. Consider uploading reports for the commit 0ff6921 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #458 +/- ## ========================================== - Coverage 73.16% 71.81% -1.35% ========================================== Files 88 84 -4 Lines 6103 5776 -327 Branches 1326 1083 -243 ========================================== - Hits 4465 4148 -317 + Misses 1357 1353 -4 + Partials 281 275 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SmithChart commented 1 year ago

No need to change this for this PR, but shouldn't we issue deprecation warning at all the other soon-to-be-deprecated features, too?

Edit: I see @fscherf has already commented on this in another PR :-) So just go ahed.

AvdN commented 1 year ago

I'll try to update this with more warnings, but of course there is plenty of room for error, because I don't understand all of the code.

On deprecated routines I will have have warning issued in the body of the routine not in the callers place (e.g. set_client_version defined in compat.py and used in settings.py) although both have a ToDo.. for 2.0

fscherf commented 1 year ago

@SmithChart, @AvdN: I created #468 with a roadmap. The PR still needs review, but I think you can use the list of tasks for Lona 2 to create warnings and deprecations

fscherf commented 11 months ago

@AvdN: This PR has been open for a long time now. Should I just take over and add the last fixes?

AvdN commented 11 months ago

Hi @fscherf, yes please, I am not sure why I didn't react to this at the first request. Sorry for that.

fscherf commented 10 months ago

@AvdN: There is nothing to be sorry about :)

fscherf commented 8 months ago

@AvdN: merged! I am so sorry that it took me so long. The test suite was broken for a long time and it took me a long time to understand why. Thanks for contributing, and for your patience!