search

lona-web-org / lona

Write responsive web apps in full python
MIT License
526 stars 27 forks source link

fix browser history #552

Closed fscherf closed 5 months ago

fscherf commented 5 months ago

Fixes #550

rschwebel commented 5 months ago

Is it intended that the patches still have a WIP: subject?

fscherf commented 5 months ago

Hi @rschwebel! As you correctly pointed out, the patches are not cleaned up yet and won't be merged in this state. I wanted some early feedback from @m-reichle if my changes fix her problem (or I suppose yours, for that matter :) ). Also I wanted to check wether the test works in CI.

While working on this, I had a lot of trouble running the browser tests locally. All calls to Playwrights page.wait_for_url('/') timeout for me and result in an InvalidStateError. It seems to be a regression because downgrading helped. I am not sure yet what to do here and if this patch will on this PR. I will try to debug it further and report my findings to Playwright upstream if necessary.